Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to main: Add new badges #2100

Merged
merged 39 commits into from
May 20, 2024
Merged

Staging to main: Add new badges #2100

merged 39 commits into from
May 20, 2024

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

anargyri and others added 30 commits April 5, 2024 20:04
@anargyri
Update SETUP.md
e112166 
Remove left-over reference to conda script that has been deleted.
@miguelgfierro
Merge pull request #2080 from recommenders-team/anargyri-patch-1
a1cd82c 
Update SETUP.md
@miguelgfierro
remove cast to array in similarity functions
c1148e1 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
remove scipy limitation
0e11e49 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@gramhagen
flattening matrix so dataframe can be built correctly
457b098 
Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>
@miguelgfierro
Merge pull request #2084 from recommenders-team/gramhagen/scipy_sar_i…
618b93e 
…ssue

flattening matrix so dataframe can be built correctly
@miguelgfierro
Adding toarray() suggested by @gramhagen
b3e3a63 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@daviddavo
Added r-precision
8d3b66c 
Signed-off-by: David Davó <david@ddavo.me>
@daviddavo
Added r-precision tests
3539525 
Signed-off-by: David Davó <david@ddavo.me>
@miguelgfierro
trying to substitude geta1 with ravel
8b31eb5 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Merge pull request #2086 from recommenders-team/daviddavo/r-precision
f7e8194 
Added r-precision
@SimonYansenZhao
Changed metric "result" to "result.toarray()"
2c00ccc 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Revert recommenders/models/sar/sar_singlenode.py
0ec2657 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Use cooccurrence.toarray()
08d9923 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
return result if isinstance(result, np.ndarray) else result.toarray()
9b0b66b 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@SimonYansenZhao
Return numpy array instead of numpy matrix
7c51605 
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
@miguelgfierro
Merge pull request #2083 from recommenders-team/miguel/scipy_sar_issue
6fb6a95 
SAR sparse multiplcation modification due to a breaking change in scipy
@miguelgfierro
Prepare for Release Recommenders 1.2.0 (#2092)
c81d56b 
* New release Recommenders 1.2.0 💥💥

* updated news

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@anargyri
Add reference to scenarios to README.md
cb4e359 
There is no link to the scenarios page from the front page, so it is hard to find. Added reference.
@anargyri
Merge pull request #2093 from recommenders-team/anargyri-patch-1
ffc9cce 
Add reference to scenarios to README.md
@miguelgfierro
Badges
c219da9 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Badges v2
de2b641 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
🐛
ed52da3 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
join slack
bf7d393 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
move slack badge down
602486a 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
move slack badge up
f2ce1f8 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
move slack badge up up
98f9c4d 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
move slack badge down with line
05bf12a 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
move slack badge down with line
93e97a1 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Trying without Recommenders
15d633b 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator Author

@anargyri and I had a meeting with the LF marketing admins (Carly), they told us that for joining the main LF server people should use this link: https://join.slack.com/t/lfaifoundation/shared_invite/zt-2iyl7zyya-g5rOO5K518CBoevyi28W6w

Also, Carly is going to talk to a person to see if we can get a link to directly join the Recommenders channel directly

daviddavo and others added 6 commits May 17, 2024 09:21
@daviddavo
Add David Davó as contributor #2099
dc00ae4 
Signed-off-by: David Davó <david@ddavo.me>
@miguelgfierro
Slack CTA
df667a5 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
width
9659dcd 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
width 300
0f7ad9e 
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@daviddavo
Fixed contributors order
7da391b 
Signed-off-by: David Davó <david@ddavo.me>
@miguelgfierro
Merge pull request #2101 from recommenders-team/contributors-daviddavo
309f441 
Add David Davó as contributor #2099
loomlike
loomlike approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelgfierro miguelgfierro merged commit 0aaa80b into main May 20, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@miguelgfierro @actions-user
Merge pull request #2100 from recommenders-team/staging
3f5ec89 
Staging to main: Add new badges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri approved these changes

@loomlike loomlike loomlike approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miguelgfierro @anargyri @loomlike @gramhagen @daviddavo @SimonYansenZhao