Support of Python 3.12 #2098
Draft
Support of Python 3.12 #2098
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
|
let's try, this can be as simple as changing a few lines of code, or we might need to fix many dependencies.
Error in Cornac dependency: |
|
Other error, it seems it's coming from dependencies: source: https://github.com/recommenders-team/recommenders/actions/runs/9090676506/job/24984293755 |
|
As the problem is with setuptools, perhaps upgrading it or forcing a more recent version should suffice. I think cornac fails just because it is the first thing to be installed with that method. According to that issue, changing the dependency to
|
|
Now the requirements are fine, but it errors after installing build dependencies and I can't see why Source: https://github.com/recommenders-team/recommenders/actions/runs/9090676506/job/24984293755 |
|
It seems the error is the same: This seems like a long problem to debug. In my experience, it is better to debug it first in local. @daviddavo would you have time to take a look? |
|
Yeah, I can try and give it some time next week |
|
I can't install lightfm on Python 3.12, this affects recommenders too |
|
Forked the repository and made a PR The package can be installed from my repository: If the pull requests wasn't approved, I can transfer ownership of this repository to recommenders-team, and then that github repository could be used in the requirements. |
Signed-off-by: David Davó <david@ddavo.me>
|
By changing temporarily changing the requirements, it works on my machine. Let's see if it works on the test groups |
|
The following command works on my machine: But perhaps my system comes with some build dependencies that are not installed in the test groups... Tomorrow I'll try and use conda to install the package on my machine and see how it goes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#2097
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.