[RLlib] Fix DreamerV3 bug: reduce_fn still passed into LearnerGroup.update_from_batch().
#45419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
…dreamer_v3_reduce_fn_issue
…dreamer_v3_reduce_fn_issue
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
approved these changes
May 24, 2024
| @@ -617,6 +617,19 @@ def set_value( | |||
| clear_on_reduce=clear_on_reduce, | |||
| ) | |||
|
|
|||
| def delete(self, *key: Tuple[str], key_error: bool = True) -> None: | |||
| """Deletes th egiven `key` from this metrics logger's stats. | |||
There was a problem hiding this comment.
Small nit: egiven -> given
…dreamer_v3_reduce_fn_issue
Signed-off-by: sven1977 <svenmika1977@gmail.com>
…dreamer_v3_reduce_fn_issue Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/utils/metrics/metrics_logger.py
…dreamer_v3_reduce_fn_issue
… crazy results (like a constant-over-time reward-loss) anymore Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…arnerGroup.update_from_batch()`. (ray-project#45419) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…arnerGroup.update_from_batch()`. (ray-project#45419) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…arnerGroup.update_from_batch()`. (ray-project#45419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DreamerV3 bug:
reduce_fnstill passed intoLearnerGroup.update_from_batch().Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.