Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove duplicate included header #45406

Merged
merged 2 commits into from
May 29, 2024
Merged

[Core] Remove duplicate included header #45406

merged 2 commits into from
May 29, 2024

Conversation

982945902
Copy link
Contributor

Why are these changes needed?

remove duplicate included header

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

remove duplicate included header
8478192 
Signed-off-by: lishuo121 <lishuo121@jd.com>
@anyscalesam anyscalesam added P2 Important issue, but not time-critical core Issues that should be addressed in Ray Core labels May 29, 2024
@anyscalesam anyscalesam requested a review from a team May 29, 2024 05:48
@anyscalesam anyscalesam self-assigned this May 29, 2024
@anyscalesam anyscalesam enabled auto-merge (squash) May 29, 2024 05:49
@github-actions github-actions bot disabled auto-merge May 29, 2024 05:49
@github-actions github-actions bot added the go Trigger full test run on premerge label May 29, 2024
@jjyao jjyao changed the title remove duplicate included header [Core] Remove duplicate included header May 29, 2024
@jjyao jjyao merged commit 1719a8f into ray-project:master May 29, 2024
8 checks passed
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@982945902 @ryanaoleary
[Core] Remove duplicate included header (ray-project#45406)
b2f97e0 
Signed-off-by: lishuo121 <lishuo121@jd.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@982945902 @ryanaoleary
[Core] Remove duplicate included header (ray-project#45406)
6869195 
Signed-off-by: lishuo121 <lishuo121@jd.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@982945902 @ryanaoleary
[Core] Remove duplicate included header (ray-project#45406)
d061556 
Signed-off-by: lishuo121 <lishuo121@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

Assignees

@anyscalesam anyscalesam

Labels
core Issues that should be addressed in Ray Core go Trigger full test run on premerge P2 Important issue, but not time-critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@982945902 @jjyao @anyscalesam