Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cluster launcher] [Azure] add option for eviction policy in azure VM template #45397

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[Cluster launcher] [Azure] add option for eviction policy in azure VM template #45397

merged 1 commit into from
Jun 3, 2024

Conversation

bthananjeyan
Copy link
Contributor

@bthananjeyan bthananjeyan commented May 17, 2024 •
edited

Why are these changes needed?

This is necessary to give users the option to pick an eviction policy (Delete vs Deallocate) when nodes in the cluster are pre-empted.

This exposes an additional option that can be set in the node_config attribute in the cluster YAML file.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bthananjeyan
Copy link
Contributor Author

@architkulkarni @ericl @hongchaodeng please let me know if you have any feedback on this PR, or if there is someone else who should be assigned to review it. Thanks!

@bthananjeyan bthananjeyan force-pushed the brijen/delete-template branch 3 times, most recently from 3967ace to 729bdca Compare May 28, 2024 18:55
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels May 29, 2024
@bthananjeyan
fix: add eviction policy to azure vm template
0d8fc30 
Signed-off-by: bthananjeyan <brijen@ambirobotics.com>
@bthananjeyan
Copy link
Contributor Author

@architkulkarni @ericl @hongchaodeng bumping this PR in case it was buried. Please let me know if you have any feedback, or if someone else can be assigned to it. I don't have the ability to assign reviewers.

@rickyyx rickyyx enabled auto-merge (squash) June 3, 2024 19:33
@github-actions github-actions bot added the go Trigger full test run on premerge label Jun 3, 2024
@rickyyx rickyyx merged commit e38e576 into ray-project:master Jun 3, 2024
8 checks passed
@bthananjeyan bthananjeyan deleted the brijen/delete-template branch June 3, 2024 22:55
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@bthananjeyan @ryanaoleary
[Cluster launcher] [Azure] add option for eviction policy in azure VM…
0c3b115 
… template (ray-project#45397)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
This is necessary to give users the option to pick an eviction policy
(Delete vs Deallocate) when nodes in the cluster are pre-empted.

<!-- Please give a short summary of the change and the problem this
solves. -->
This exposes an additional option that can be set in the `node_config`
attribute in the cluster YAML file.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [x] This PR is not tested :(

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1207339070862431

Signed-off-by: bthananjeyan <brijen@ambirobotics.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@bthananjeyan @ryanaoleary
[Cluster launcher] [Azure] add option for eviction policy in azure VM…
09b962c 
… template (ray-project#45397)

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
This is necessary to give users the option to pick an eviction policy
(Delete vs Deallocate) when nodes in the cluster are pre-empted.

<!-- Please give a short summary of the change and the problem this
solves. -->
This exposes an additional option that can be set in the `node_config`
attribute in the cluster YAML file.

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [x] This PR is not tested :(

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1207339070862431

Signed-off-by: bthananjeyan <brijen@ambirobotics.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng hongchaodeng approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni architkulkarni is a code owner

Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core go Trigger full test run on premerge triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bthananjeyan @hongchaodeng @rickyyx @anyscalesam