Add an all-in-one devcontainer and make use of -j on production builder #8151
+166
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleos89
reviewed
Mar 7, 2024
| - "3306:3306" # allow DB connections from host | ||
| volumes: | ||
| - "rathenadb:/var/lib/mysql" # save database to local disk | ||
| - "../../sql-files/:/docker-entrypoint-initdb.d" # initialize db with ./sql-files |
There was a problem hiding this comment.
Is this a little dangerous with the tools folder in sql-files? The conversion of engine types and the MD5 password setting (if the server config isn't setup for this password type).
Unless I'm hyping this up and it doesn't crawl to sub-directories, then ignore me!
There was a problem hiding this comment.
It does map the directory to the container but i think the container only queries for sql files. The change I needed to do was because the dir is now a level below
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion around the readme of the docker part, we did not remove the wording saying the containers are not suited for production when we split each server to its container.
N/D
This PR aims to create two different folders of docker-compose files, mostly restore the old one and divide them into "production" and "development", being "production" the one with separate containers and the latter the one with an all-in-one container.