Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta openldap v2.8 backport #45513

Merged
merged 2 commits into from
May 21, 2024

Conversation

bigkevmcd
Copy link
Contributor

Issue:

Backport of #45507 for release/v2.8

Problem

Solution

Same as it was for #45507

Testing

Engineering Testing

Manual Testing

Automated Testing

  • Test types added/modified:
    • Unit
    • Integration (Go Framework)
    • Integration (v2prov Framework)
    • Validation (Go Framework)
    • Other - Explain: EXPLAIN
    • None
    • REMOVE NOT APPLICABLE BULLET POINTS ABOVE
  • If "None" - Reason: EXPLAIN THE REASON
  • If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO

QA Testing Considerations

Regressions Considerations

TODO

Existing / newly added automated tests that provide evidence there are no regressions:

  • TODO

@bigkevmcd bigkevmcd changed the title Okta openldap v28 backport Okta openldap v2.8 backport May 16, 2024
@bigkevmcd bigkevmcd force-pushed the okta-openldap-v28-backport branch 6 times, most recently from bb6348e to de1de94 Compare May 17, 2024 14:46
@bigkevmcd bigkevmcd requested a review from crobby May 20, 2024 07:43
This migrates the OKTA OpenLDAP password to a Secret.
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change to test_dns.py intentional here? It didn't appear in the 2.9 version of this fix.

@bigkevmcd
Copy link
Contributor Author

@crobby I suspect I'll need to forward-port it, it was failing repeatedly during the test run.

Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@andreas-kupries andreas-kupries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bigkevmcd bigkevmcd merged commit d4938bf into rancher:release/v2.8 May 21, 2024
2 checks passed
@bigkevmcd bigkevmcd deleted the okta-openldap-v28-backport branch May 21, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants