[DRAFT] Add framework for global role integration tests #45450
+281
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonCrowther
force-pushed
the
global-roles-integration-tests
branch
from
d0c4442
to
752d0f5
Compare
raulcabello
reviewed
Jun 6, 2024
| name: "create primary cluster role with generated name", | ||
| globalRole: v3.GlobalRole{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-gr", |
There was a problem hiding this comment.
I would use a different name to avoid conflics with the previous test. I got an error saying that the GlobalRole existed because it was still deleting the previous one.
| assert.NoError(t, err) | ||
|
|
||
| // Assert any desired role fields | ||
| assert.Equal(t, test.globalRole.Name, role.OwnerReferences[0].Name) |
There was a problem hiding this comment.
nit: I think we can remove this as this is tested in line 218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: