Add microphone toggle button #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also no mic
I have attached |
christopher3278
approved these changes
Nov 29, 2023
# Conflicts: # app/src/main/cpp/MelonDSAndroidJNI.cpp # app/src/main/java/me/magnum/melonds/MelonEmulator.kt # melonDS-android-lib
|
I merged the new updates and I created a pull request on the lib repo rafaelvcaetano/melonDS-android-lib#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new button to toggle the microphone input. The main use is to quickly toggle the software blow on and off for games that require it (but it also disables other sources, so if the mic is set to real input it will also get disabled, and if it's set to disabled it will stay always disabled)
I had a quick look at the code while implementing this, so I don't know if it's the most effective way
I don't think I'll work more on this since it does what I needed, but it could be modified from a toggle to be a normal button, which blows when it's pressed
Also, I give up on git. I tried to push on the submodule and it may have made a mess. Let me know if I also need to create a pull request from the submodule, or just feel free to copy/paste the code (rafaelvcaetano/melonDS-android-lib@1175c71)