fix: better handle errors from database calls #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfdking
force-pushed
the
fixing_run_test_if_dont_run
branch
3 times, most recently
from
104e08b
to
d06b52b
Compare
benfdking
force-pushed
the
fixing_run_test_if_dont_run
branch
from
d06b52b
to
5986485
Compare
| } | ||
| } | ||
|
|
||
| message FailedRunResults { | ||
| QueryResult query_result = 1; | ||
| } | ||
|
|
||
| // FailedRunMessage is a message that contains a message that can be displayed | ||
| // to the user when a test fails. This shoudl be used when the failure is not |
There was a problem hiding this comment.
Suggested change
| // to the user when a test fails. This shoudl be used when the failure is not | |
| // to the user when a test fails. This should be used when the failure is not |
louisjoecodes
approved these changes
May 22, 2024
benfdking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.