ci: Implement Semantic Versioning for Docker Image Deployment #3474
Conversation
| id: version | ||
| run: | | ||
| FULL_VERSION=${{ steps.vars.outputs.tag }} | ||
| MAJOR_VERSION=$(echo $FULL_VERSION | cut -d '.' -f 1) |
There was a problem hiding this comment.
Thank you for elaborating on the other comments!
Before I approve, I have a final thing to decide on. I wonder if we should remove major version tagging.
I don't think it makes much sense based on our current releases. What do you think?
Maybe @generall has a good opinion on this.
There was a problem hiding this comment.
Yes makes sense, but I feel maintaining major tags is a standard practice & usually beneficial long-term. Your call, though.
| DOCKERHUB_TAG_LATEST="qdrant/qdrant:latest" | ||
| TAGS="-t ${DOCKERHUB_TAG} -t ${DOCKERHUB_TAG_LATEST}" | ||
| TAGS="-t ${DOCKERHUB_TAG} -t ${DOCKERHUB_TAG_MAJOR} -t ${DOCKERHUB_TAG_MINOR} -t ${DOCKERHUB_TAG_LATEST}" |
There was a problem hiding this comment.
Before we can merge this, I believe we first need to update our logic in cloud.qdrant.io (link to a private repo): https://github.com/qdrant/qdrant-cloud-cluster-api/blob/6d759e0d5293c99e8ceb0db9e9ce035a8c1b2ad6/cluster_api/cluster/util.py#L75-L82
Our code currently will grab the first-listed image that has the same sha256 digest as the "latest" image, and only lets people deploy that version of Qdrant for new clusters, which is a bit naive. We'd need to make the code ignore any images that don't strictly match vX.Y.Z.
Added major/minor tags support for docker image workflow.
linked to issue #1957
All Submissions:
devbranch. Did you create your branch fromdev?