Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust user agent version automatically #20864

Merged
merged 1 commit into from
May 20, 2024

Conversation

Chocobo1
Copy link
Member

The version calculation is an estimation and it will drift off after some time. Hopefully the drift offset won't be noticeable within a few years.

Also switched the user agent to Windows 10 which has the largest portion of users to avoid standing out from the crowd.

@Chocobo1 Chocobo1 added the Network Issues related to network connectivity label May 18, 2024
@Chocobo1 Chocobo1 added this to the 5.0 milestone May 18, 2024
The version calculation is an estimation and it will drift off after some time. Hopefully the
drift offset won't be noticeable within a few years.

Also switched the user agent to Windows 10 which has the largest portion of users to avoid
standing out from the crowd.
@glassez
Copy link
Member

glassez commented May 18, 2024

Also switched the user agent to Windows 10 which has the largest portion of users to avoid standing out from the crowd.

You untie it from a specific browser version, but you bind it to a specific OS version (moreover, not the most recent), which is subject to the same obsolescence problem. Is this a good idea?

@Chocobo1
Copy link
Member Author

You untie it from a specific browser version, but you bind it to a specific OS version (moreover, not the most recent), which is subject to the same obsolescence problem. Is this a good idea?

Not many options available here IMO. Win11 market share is still relatively small compared to Win10.

@Chocobo1
Copy link
Member Author

@glassez
Copy link
Member

glassez commented May 18, 2024

You untie it from a specific browser version, but you bind it to a specific OS version (moreover, not the most recent), which is subject to the same obsolescence problem. Is this a good idea?

Not many options available here IMO. Win11 market share is still relatively small compared to Win10.

I would leave it as it is. "Linux x86_64" looks less affected by time. Besides, did we have any problems with it?..

@Chocobo1
Copy link
Member Author

Besides, did we have any problems with it?..

No one reports it but it is too easy to identify/fingerprint an qbt user as the "Linux x86_64" user base is too damn small.

@glassez
Copy link
Member

glassez commented May 18, 2024

No one reports it but it is too easy to identify/fingerprint an qbt user as the "Linux x86_64" user base is too damn small.

If we proceed from the same considerations, Firefox userbase is also (relatively) small.

@Chocobo1
Copy link
Member Author

If we proceed from the same considerations, Firefox userbase is also (relatively) small.

I've considered using chrome user agent but its release schedule is too unpredictable and also the composition is too complex to get it right.

@glassez
Copy link
Member

glassez commented May 18, 2024

If we proceed from the same considerations, Firefox userbase is also (relatively) small.

I've considered using chrome user agent but its release schedule is too unpredictable and also the composition is too complex to get it right.

Ok.
Last question. Is there any chance that the calculation algorithm you are using will not produce an unreleased version in some corner case (under normal conditions)?
It is preferable to look plausible than to necessarily use the latest version.

@Chocobo1
Copy link
Member Author

Chocobo1 commented May 18, 2024

Last question. Is there any chance that the calculation algorithm you are using will not produce an unreleased version in some corner case (under normal conditions)?

The firefox release schedule looks to me that they release every 28 days (on average). The PR uses 30 days so it should slowly lag behind the latest release. Even if the calculation is slightly ahead of the release (which should be very rare) it is no big problem because it will be the same as Firefox Beta or Firefox Developer Edition (which still are valid user agents). Those FF betas uses +1 version from the released version.
Another possibility is that FF might delay a release but manually checking the history release dates I haven't noticed such thing.

@xavier2k6
Copy link
Member

Just posting this as an FYI / post a question.

Should we defer this PR & use Firefox 128 (ESR) / 2024-07-09 for the base version/date when available??

Is this PR or the other user-agent PR going to be backported to 4.6.x branch?

@Chocobo1
Copy link
Member Author

Chocobo1 commented May 18, 2024

Should we defer this PR & use Firefox 128 (ESR) / 2024-07-09 for the base version/date when available??

Probably not. The drift offset shouldn't be noticeable within a year or two. The maintenance sync/update could be performed once per 5, 6 years (if it really requires).

Is this PR or the other user-agent PR going to be backported to 4.6.x branch?

The other previous PR should be backported. This PR is suited for qbt v5 IMO.

@Chocobo1 Chocobo1 merged commit a126a7b into qbittorrent:master May 20, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the browser_fingerprint branch May 20, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network Issues related to network connectivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants