Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GaussianNoise #8381

Merged
merged 6 commits into from
May 31, 2024
Merged

Add GaussianNoise #8381

merged 6 commits into from
May 31, 2024

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Apr 17, 2024

Fixes #6192
Fixes #6233

cc @vfdev-5

Copy link

pytorch-bot bot commented Apr 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8381

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 13 New Failures, 4 Unrelated Failures

As of commit d926a83 with merge base b0f9f7b (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @Richienb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

clip (bool, optional): Whether to clip the values in ``[0, 1]`` after adding noise. Default is True.
"""

def __init__(self, mean: float = 0.0, sigma: float = 0.1, clip=True) -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sigma (σ) should instead be called var for "variance". For example, mean is not called mu (μ).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair @Richienb , I can't claim mean and sigma are the best name combination, but unfortunately for consistency this is probably what we'll need to use, as these are the names that are already used by GaussianBlur.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's save this for a future breaking change.

@NicolasHug NicolasHug marked this pull request as ready for review May 31, 2024 09:37
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Richienb , as you've seen I've made a few changes to the original implementation, but this LGTM now. In particular the transform enforces tensors with float dtype (PIL isn't supported). We might add support for that later but that would require a dtype conversion to avoid over/underflows, so it's best to treat it separately. Thank you again for the PR!

@NicolasHug NicolasHug merged commit 6e18cea into pytorch:main May 31, 2024
60 of 79 checks passed
facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2024
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D58283845

fbshipit-source-id: e3cadf800c582383a28b9e097263084a9aa40364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gaussian noise transformation
4 participants