[FBcode->GH] [fbcode] Reduce log spam from torchvision video reader #8333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Sample 1/1000 to avoid log spam:
{F1365743020}
Reviewed By: dsesh
Differential Revision: D53062741
fbshipit-source-id: a808210c1dda98b77c7d88e850f607b53e8fa562
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8333
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 19 New FailuresAs of commit 9c2bfbf with merge base 375cfdf ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
We can't import this diff as it's breaking the CI with a compilation error. I'll close the PR and backout the diff in D58283929 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Summary: Original commit changeset: a808210c1dda Original Phabricator Diff: D53062741 Unfortunately I have to backout D53062741 as it is not compiling properly on the torchvision GitHub repo (source of truth): This [this PR](#8333) which includes the changes from D53062741 but fails with ``` /pytorch/vision/torchvision/csrc/io/video_reader/video_reader.cpp:477:17: error: ‘ERROR’ was not declared in this scope; did you mean ‘AVERROR’? 477 | LOG_EVERY_N(ERROR, 1000) << "Decoder initialization has failed"; | ^~~~~ Traceback (most recent call last): File "/home/ec2-user/actions-runner/_work/vision/vision/test-infra/.github/scripts/run_with_env_secrets.py", line 101, in <module> main() File "/home/ec2-user/actions-runner/_work/vision/vision/test-infra/.github/scripts/run_with_env_secrets.py", line 97, in main run_cmd_or_die(f"docker exec -t {container_name} /exec") File "/home/ec2-user/actions-runner/_work/vision/vision/test-infra/.github/scripts/run_with_env_secrets.py", line 38, in run_cmd_or_die raise RuntimeError(f"Command {cmd} failed with exit code {exit_code}") RuntimeError: Command docker exec -t f02046f9ef9ce5646ae4a84fe51204d4594ecbcbcc66e4572c681290939d87c4 /exec failed with exit code 1 | AVERROR /pytorch/vision/torchvision/csrc/io/video_reader/video_reader.cpp:477:5: error: ‘LOG_EVERY_N’ was not declared in this scope; did you mean ‘C10_LOG_EVERY_N’? 477 | LOG_EVERY_N(ERROR, 1000) << "Decoder initialization has failed"; | ^~~~~~~~~~~ | C10_LOG_EVERY_N /pytorch/vision/torchvision/csrc/io/video_reader/video_reader.cpp:510:17: error: ‘ERROR’ was not declared in this scope; did you mean ‘AVERROR’? 510 | LOG_EVERY_N(ERROR, 1000) << "Miss video stream"; | ^~~~~ | AVERROR /pytorch/vision/torchvision/csrc/io/video_reader/video_reader.cpp:510:5: error: ‘LOG_EVERY_N’ was not declared in this scope; did you mean ‘C10_LOG_EVERY_N’? 510 | LOG_EVERY_N(ERROR, 1000) << "Miss video stream"; | ^~~~~~~~~~~ | C10_LOG_EVERY_N ``` It seems that `LOG_EVERY_N` is only present internally on fbcode because of some internal transitive dependency. Reviewed By: vmoens Differential Revision: D58283929 fbshipit-source-id: ac5f2f389b8b12ed019cb5aaa8b331e7c89a9acd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sample 1/1000 to avoid log spam:
{F1365743020}
Reviewed By: dsesh
Differential Revision: D53062741
fbshipit-source-id: a808210c1dda98b77c7d88e850f607b53e8fa562