Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recipe_state from eleuther config #900

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

rohan-varma
Copy link
Member

@rohan-varma rohan-varma commented Apr 30, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

  • Removes recipe_state from the eleuther config, as we only need to work with final finetuned model checkpoints and not intermediate checkpoints. This simplifies the config - ideally we'd also remove the output_dir as we're not saving checkpoints, but this is required to instantiate the checkpointer.

Test plan

Run eval: tune run eleuther_eval --config eleuther_evaluation che ckpointer=torchtune.utils.FullModelMetaCheckpointer checkpointer.checkpoint_files=["m eta_model_0.pt"] checkpointer.checkpoint_dir=/tmp/tt-compile-out/

Copy link

pytorch-bot bot commented Apr 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/900

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit eb00259 with merge base aa65012 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2024
@rohan-varma rohan-varma merged commit 437241f into main Apr 30, 2024
27 checks passed
@joecummings joecummings deleted the rm_recipe_ckpt branch May 2, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants