Fix torchrec rowwise adagrad implementation #2015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57307271 |
|
cc @YLGH |
Summary: Apparently we flipped the order of taking power 2 and taking mean. Differential Revision: D57307271
henrylhtsang
force-pushed
the
export-D57307271
branch
from
f38c6f3
to
a5f60b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57307271 |
|
whoops, but does anyone actually use this? :p |
|
@YLGH so far not really afaik lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Apparently we flipped the order of taking power 2 and taking mean.
Differential Revision: D57307271