refactor mean pooling tests and test for all sharding types #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: mean pooling tests were verbose and in some cases not catching all cases (twrw requires 4 gpus to properly test) we refactor the tests here to apply for all sharding types and appropriately test for twrw case. one_step_cleaner_code Differential Revision: D56649340
zainhuda
force-pushed
the
export-D56649340
branch
from
f76e38c
to
d2330ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
mean pooling tests were verbose and in some cases not catching all cases (twrw requires 4 gpus to properly test)
we refactor the tests here to apply for all sharding types and appropriately test for twrw case.
Differential Revision: D56649340