[TD] Improved historical file failure correlation #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
clee2000
force-pushed
the
csl/improved_historical_failure_correlation
branch
from
7fde00c
to
8d78a28
Compare
clee2000
force-pushed
the
csl/improved_historical_failure_correlation
branch
from
8d78a28
to
a3d8360
Compare
ZainRizvi
reviewed
May 15, 2024
ZainRizvi
approved these changes
May 20, 2024
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 20, 2024
Some tests don't get run through pytest and pytest crashes when a test segfaults, so in both caess, the pytest cache won't have an entry (similar to pytorch/test-infra#5205). Instead, manually upload/download an extra file that lists the failing test files Technically this would be more general than the pytest cache Pull Request resolved: #126315 Approved by: https://github.com/ZainRizvi
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 21, 2024
Some tests don't get run through pytest and pytest crashes when a test segfaults, so in both caess, the pytest cache won't have an entry (similar to pytorch/test-infra#5205). Instead, manually upload/download an extra file that lists the failing test files Technically this would be more general than the pytest cache Pull Request resolved: #126315 Approved by: https://github.com/ZainRizvi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests don't generate xml and when a test segfaults, no xml gets created, so these two cases won't show up in the failed_tests_run table.
Instead, query the td_test_failure_stats_v2 table since that is populated by test file failure/the name returned by discover tests.
Split up historical class and historical file correlation calculations since they use different queries now
Reuse as many functions as possible from utils.py