[hud] add style cues to the failure symbol (X) based on the error line #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
clee2000
reviewed
May 1, 2024
| }: { | ||
| children: React.ReactNode; | ||
| }) { | ||
| const [stylishFailures, setStylishFailures] = useState<boolean>(false); |
There was a problem hiding this comment.
nit: can you use the function that saves the preference locally? I think it's called usePreference
izaitsevfb
force-pushed
the
hud-stylish-failures
branch
from
7e96bda
to
f10d958
Compare
|
Discovered some interference with filtering, marking as draft for now. |
|
Superceded by #5244 |
izaitsevfb
added a commit
that referenced
this pull request
May 21, 2024
Supersedes #5155 (this version is much faster, doesn't interfere with collapsing, and arguably slightly better looking, also sillier) An option to replace red `X` with a unique pixel-art "monster" that corresponds to the job failure line. Allows to detect streaks of the same failures at a glance. Calculates the hash based on the job failure line (without whitespaces and digits). **Potential TODO:** I slightly messed up the spritesheet size (that's why the size and position numbers are real). If this version looks good enough this could be improved later. **Screenshots**: <img width="1530" alt="image" src="https://github.com/pytorch/test-infra/assets/108101595/74bb4340-9b3e-47b1-adc0-b7c53fa62f7e"> <img width="754" alt="image" src="https://github.com/pytorch/test-infra/assets/108101595/3d7bc8c4-5453-4e2e-bf7f-3df9aca21d90"> Note: group icon (X) is not changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An option to make the grid slightly more ugly, but at the same time allow seeing streaks of related failures at a glance.
Implementation:
Demo:
output.mp4
Streaks of failures are now visible, even if they migrate between jobs: