Remove linter rerun logic #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
huydhn
approved these changes
Feb 8, 2024
kit1980
force-pushed
the
sdym/linter-no-rerun
branch
from
cf55e9d
to
a8e9418
Compare
kit1980
added a commit
to pytorch/pytorch
that referenced
this pull request
May 21, 2024
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 21, 2024
Related to pytorch/test-infra#4934 Lint workflow now uses Docker, so there should not be network-related errors for pip installing stuff. Pull Request resolved: #126806 Approved by: https://github.com/seemethere, https://github.com/ZainRizvi, https://github.com/huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lint jobs are re-run even if it's an actual lint failure, because
step.name.toLowerCase().includes("(nonretryable)")doesn't work since moving to Nova.This PR removes the lint retrying logic in conjunction with removing lint from retryable workflows in pytorch/pytorch#126806