New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AOTI] Fix a codegen issue when .item() is used for kernel arg #126575

Closed

desertfire wants to merge 11 commits into gh/desertfire/391/base from gh/desertfire/391/head

Contributor

desertfire commented May 17, 2024 •

edited

Stack from ghstack (oldest at bottom):

Summary: fixes #126574 . Pass kernel argument type information into generate_args_decl, so it can generate the argument declaration instead of relying on string matching.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

1c4d1dd

Summary: fixes #126574

[ghstack-poisoned]

desertfire mentioned this pull request

[AOTI] Codegen None as empty tensor #126369

Closed

pytorch-bot bot commented May 17, 2024 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126575

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 74a8381 with merge base acfe237 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / cuda12.1-py3.12-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
inductor/test_aot_inductor.py::AOTInductorTestNonABICompatibleCuda::test_bmm_multiple_dynamic_non_abi_compatible_cuda

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor release notes: foreach_frontend labels

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

0dffd89

Summary: fixes #126574

ghstack-source-id: c62b593fcac9bc0cefcf23020cdc5dbb5f18918e
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

4af1478

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

99bde56

Summary: fixes #126574

ghstack-source-id: 15c7f73dda686e51ee7eb3e04d759a88242e9502
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

1ff5aae

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

46b3599

Summary: fixes #126574

ghstack-source-id: 4ea335c98fee4514d19abbb418b55f7c4b67b8bb
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

2ff97a8

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

4ca3945

Summary: fixes #126574

ghstack-source-id: 79a9511396c2d47f158233b63306a5a4418e4b87
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

a81eddb

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

This was referenced May 20, 2024

[AOTI] Disable stack allocation for OSS #125732

Closed

[AOTI][not for review] Test cpp_wrapper mode #125733

Open


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

81f24d5

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

b72cfe2

Summary: fixes #126574

ghstack-source-id: 05d212b3001d2419803fe1be3b6c47f86b70ca1f
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

7a1c1c5

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

099938c

Summary: fixes #126574

ghstack-source-id: 18d8596d440a4f0f4048aee9beaf5ca1fa27affa
Pull Request resolved: #126575


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

34b5fe5

… arg"

Summary: fixes #126574

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire mentioned this pull request

[AOTI] Add more fallback ops #126720

Closed

desertfire requested review from chenyang78 and angelayi

May 20, 2024 21:47

desertfire added 2 commits

May 20, 2024 15:02


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

472e3d7

… arg"


Summary: fixes #126574 . Pass kernel argument type information into generate_args_decl, so it can generate the argument declaration instead of relying on string matching.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

a630ac0

… arg"


Summary: fixes #126574 . Pass kernel argument type information into generate_args_decl, so it can generate the argument declaration instead of relying on string matching.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

chenyang78 approved these changes

View reviewed changes

desertfire added topic: not user facing and removed release notes: foreach_frontend labels


          Update on "[AOTI] Fix a codegen issue when .item() is used for kernel…

74a8381

… arg"


Summary: fixes #126574 . Pass kernel argument type information into generate_args_decl, so it can generate the argument declaration instead of relying on string matching.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]

desertfire added a commit that referenced this pull request


          [AOTI] Fix a codegen issue when .item() is used for kernel arg

48a91f6

Summary: fixes #126574

ghstack-source-id: 230f28a57e262355e78a42588960af4cc04c7902
Pull Request resolved: #126575

Contributor Author

desertfire commented May 21, 2024

@pytorchbot merge

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented May 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented May 21, 2024

Merge failed

Reason: 18 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable)

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor Author

desertfire commented May 21, 2024

@pytorchbot merge -f "CI flaky"

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented May 21, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

b40fb2d

pytorchmergebot removed the merging label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment