Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune back configs #126570

Closed
wants to merge 3 commits into from
Closed

prune back configs #126570

wants to merge 3 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented May 17, 2024

Stack from ghstack (oldest at bottom):

We had a previous PR that added configs for an internal model. Running the below script on output from autotuning, we can prune back the added configs with negligible perf loss: P1365917790.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126570

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4be56a3 with merge base 7d34cfd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request May 17, 2024
ghstack-source-id: c8a52a1e514cc9c7a609155c3b69fe2c0402dc34
Pull Request resolved: #126570
@eellison eellison requested a review from nmacchioni May 17, 2024 20:00
@eellison eellison added the topic: not user facing topic category label May 17, 2024
Copy link
Contributor

@nmacchioni nmacchioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Wondering if you got a perf run with this new set of configs?

@eellison
Copy link
Contributor Author

eellison commented May 20, 2024

Yea, just did inference since training wasn't as affected when in your benchmark run:

image

Note - base commit slightly different, obviously don't expect speedups here, but shouldn't be any large slowdowns.

@eellison eellison added the ciflow/trunk Trigger trunk jobs on your pull request label May 21, 2024
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eellison
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/eellison/652/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/126570)

pytorchmergebot pushed a commit that referenced this pull request May 21, 2024
ghstack-source-id: ea8e614d335329d3c2fb4a37603f216e6f25c0b4
Pull Request resolved: #126570

We had a previous PR that added configs for an internal model. Running the below script on output from autotuning, we can prune back the added configs with negligible perf loss: P1365917790.


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
eellison added a commit that referenced this pull request May 21, 2024
ghstack-source-id: 6c3785496e680f08a35be7b8f6dae2705af267ae
Pull Request resolved: #126570
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@nmacchioni
Copy link
Contributor

@eellison force merge should be alright here, we know perf is good and I don't see how this could break things.

@eellison
Copy link
Contributor Author

@pytorchbot merge --force "already tested, no risk of causing ci errors"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants