-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Split Build] Build torch wheels using external wheel #126564
base: gh/PaliC/239/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126564
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit df93ab3 with merge base 6edf989 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 11307edeed9f2b9221f3c544f918345f48df98d2 Pull Request resolved: pytorch#126564
@@ -1,30 +1,27 @@ | |||
cmake_minimum_required(VERSION 3.18 FATAL_ERROR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to format it in such way so only your changes are introduced ? Its really hard to see what are your changes from the original ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since previous PR and this one modify same files. Maybe it will make sense to merge both PRs ?
ghstack-source-id: 5570c4eb049633e1f5523695cfdfde517191d37d Pull Request resolved: pytorch#126328 [Split Build] Build using c10 ghstack-source-id: 5570c4eb049633e1f5523695cfdfde517191d37d Pull Request resolved: pytorch#126325 [Split Build] Build torch wheels using external wheel ghstack-source-id: 5570c4eb049633e1f5523695cfdfde517191d37d Pull Request resolved: pytorch#126564
Stack from ghstack (oldest at bottom):
Builds torch_xxx libraries also using another wheel (given the BUILD_PYTHON_ONLY=1 option).
For testing we ran smoke tests and they pass to the point the current master does (fails max_autotune).
Here is the breakdown of depenendencies.
We run
to produce