-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Export quantized::layer_norm to LayerNormalization in opset >=17 #126555
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126555
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 10 Unrelated FailuresAs of commit c5b5b5e with merge base 31ea829 (): NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @NathanielB123 Please sign CLA as it suggests. |
I think I count as corporate contributor given I am interning at Arm working on ML stuff right now. I sent the email to the CLA manager so I guess I just have to wait now (will also ask on Monday to double check how this stuff works). |
I remember it's easier to sign as individual contributor. |
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Oops sorry I forgot about this. I asked around a bit at work and it sounds like the process for getting open-source contributions approved is stupidly complicated and the standard approach in my team is to sidestep this by only opening GH issues, not PRs. Very dumb but ¯\_(ツ)_/¯, closing. If someone was to create their own PR fixing the same root issue in perhaps a vaguely similar way (because the fix really is quite obvious) I assume there would be no problems, but IANAL. |
Thanks for trying! I will open another PR for this. |
Fixes #126160