Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Export quantized::layer_norm to LayerNormalization in opset >=17 #126555

Closed
wants to merge 2 commits into from

Conversation

NathanielB123
Copy link

Fixes #126160

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126555

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 10 Unrelated Failures

As of commit c5b5b5e with merge base 31ea829 (image):

NEW FAILURE - The following job has failed:

  • pull / linux-focal-cuda12.4-py3.10-gcc9 / build (gh)
    /var/lib/jenkins/workspace/aten/src/ATen/cuda/CUDASparseDescriptors.h:119:68: error: ‘cusparseStatus_t cusparseCreateBsrsm2Info(bsrsm2Info**)’ is deprecated: The routine will be removed in the next major release [-Werror=deprecated-declarations]

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

  • pull / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build (gh) (#127104)
    /var/lib/jenkins/workspace/aten/src/ATen/cuda/CUDASparseDescriptors.h:119:68: error: ‘cusparseStatus_t cusparseCreateBsrsm2Info(bsrsm2Info**)’ is deprecated: The routine will be removed in the next major release [-Werror=deprecated-declarations]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 17, 2024
Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Not Signed

@titaiwangms
Copy link
Collaborator

Hi @NathanielB123 Please sign CLA as it suggests.

@titaiwangms titaiwangms added topic: new features topic category module: onnx Related to torch.onnx labels May 17, 2024
@NathanielB123
Copy link
Author

Hi @NathanielB123 Please sign CLA as it suggests.

I think I count as corporate contributor given I am interning at Arm working on ML stuff right now. I sent the email to the CLA manager so I guess I just have to wait now (will also ask on Monday to double check how this stuff works).

@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 20, 2024
@titaiwangms
Copy link
Collaborator

Hi @NathanielB123 Please sign CLA as it suggests.

I think I count as corporate contributor given I am interning at Arm working on ML stuff right now. I sent the email to the CLA manager so I guess I just have to wait now (will also ask on Monday to double check how this stuff works).

I remember it's easier to sign as individual contributor.

titaiwangms
titaiwangms previously approved these changes May 22, 2024
@titaiwangms titaiwangms reopened this May 30, 2024
@pytorch-bot pytorch-bot bot dismissed titaiwangms’s stale review May 30, 2024 21:34

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@NathanielB123
Copy link
Author

NathanielB123 commented May 31, 2024

Oops sorry I forgot about this. I asked around a bit at work and it sounds like the process for getting open-source contributions approved is stupidly complicated and the standard approach in my team is to sidestep this by only opening GH issues, not PRs. Very dumb but ¯\_(ツ)_/¯, closing.

If someone was to create their own PR fixing the same root issue in perhaps a vaguely similar way (because the fix really is quite obvious) I assume there would be no problems, but IANAL.

@titaiwangms
Copy link
Collaborator

Oops sorry I forgot about this. I asked around a bit at work and it sounds like the process for getting open-source contributions approved is stupidly complicated and the standard approach in my team is to sidestep this by only opening GH issues, not PRs. Very dumb but ¯_(ツ)_/¯, closing.

If someone was to create their own PR fixing the same root issue in perhaps a vaguely similar way (because the fix really is quite obvious) I assume there would be no problems, but IANAL.

Thanks for trying! I will open another PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ONNX] Export quantized::layer_norm to LayerNormalization in opset >=17
4 participants