Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submodule] Remove third-party onnx-tensorrt #126542

Closed
wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 17, 2024

It seems that tensorrt is not used by the C++ code, may be due to the removal of Caffe2.

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126542

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit e6220c4 with merge base 7dae7d3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Remove caffe2 trt build script Remove Caffe2 tensorrt build scripts May 17, 2024
@cyyever cyyever force-pushed the onnxtrt branch 2 times, most recently from 93b77fc to 31dd817 Compare May 18, 2024 00:01
@cyyever cyyever added the ciflow/binaries Trigger all binary build and upload jobs on the PR label May 18, 2024
@cyyever cyyever marked this pull request as draft May 18, 2024 00:56
@cyyever cyyever marked this pull request as ready for review May 18, 2024 06:32
@cyyever cyyever changed the title Remove Caffe2 tensorrt build scripts Remove Caffe2 tensorrt CMake scripts May 18, 2024
@cyyever cyyever changed the title Remove Caffe2 tensorrt CMake scripts Remove Caffe2 tensorrt CMake logic May 18, 2024
@cyyever cyyever changed the title Remove Caffe2 tensorrt CMake logic Remove Caffe2 tensorrt code in CMake May 18, 2024
@cyyever cyyever requested a review from Skylion007 May 18, 2024 23:14
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 18, 2024
@cyyever cyyever changed the title Remove Caffe2 tensorrt code in CMake Remove third-party onnx-tensorrt May 18, 2024
@cyyever cyyever changed the title Remove third-party onnx-tensorrt [Submodule] Remove third-party onnx-tensorrt May 18, 2024
@ezyang ezyang added the topic: not user facing topic category label May 19, 2024
@ezyang
Copy link
Contributor

ezyang commented May 19, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased onnxtrt onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout onnxtrt && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor

ezyang commented May 19, 2024

@pytorchbot merge -f "two failures look unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the onnxtrt branch May 23, 2024 07:48
pytorchmergebot pushed a commit that referenced this pull request May 28, 2024
titaiwangms pushed a commit to titaiwangms/pytorch that referenced this pull request May 28, 2024
Aidyn-A pushed a commit to tinglvv/pytorch that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants