Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submodule] Remove third-party CUB #126540

Closed
wants to merge 1 commit into from
Closed

[Submodule] Remove third-party CUB #126540

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 17, 2024

Because it was updated 4 years ago, and now all supported CUDA versions provide CUB.

Copy link

pytorch-bot bot commented May 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126540

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2a78985 with merge base 3f28906 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever added the topic: not user facing topic category label May 17, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented May 17, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

This PR updates submodules third_party/cub

If those updates are intentional, please add "submodule" keyword to PR title/description.

@cyyever cyyever changed the title Remove third-party CUB [Submodule] Remove third-party CUB May 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented May 18, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the cub branch May 18, 2024 02:44
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Because it was updated 4 years ago, and now all supported CUDA versions provide CUB.

Pull Request resolved: pytorch#126540
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants