Improve cmake testing setup #3666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add build/Test.cmake and provide helper function for users to add tests targets Example: ``` et_cxx_test(my_test SOURCES my_test.cpp EXTRA_LIBS portable_kernels) ``` User need to invoke et_cxx_test and add their srcs/deps. Note: gtest, gmock, executorch are added to deps by default. * Update existign CMakeLists.txt and template test/utils/OSSTest.cmake.in for that * In test/run_oss_cpp_tests.sh, probe tests so user don't need to add them manually We will utilize add_test from cmake later Test Plan: `sh test/run_oss_cpp_tests.sh`
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3666
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 229a90f with merge base dc36ef7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I will update examples afterwards |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dbort
approved these changes
May 20, 2024
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign merged this pull request in 788676f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
User need to invoke et_cxx_test and add their srcs/deps. Note: gtest, gmock, executorch are added to deps by default.
Test Plan:
sh test/run_oss_cpp_tests.sh