Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only unset HOME when running cmake as root #3512

Merged
merged 1 commit into from
May 21, 2024
Merged

Only unset HOME when running cmake as root #3512

merged 1 commit into from
May 21, 2024

Commits on May 4, 2024

  1. Only unset HOME when running cmake as root 

    This hack is required to work around pytorch/test-infra#5091, which
runs some CI jobs as root, which buck2 doesn't like.

But we saw in pytorch#3502 that this can break things for some normal users.

Reduce the blast radius of this hack, only modifying HOME when actually
running as root.
    @dbort
    dbort committed May 4, 2024
    Configuration menu
    Copy the full SHA
    9904f73 View commit details
    Browse the repository at this point in the history