New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use c++11 for size test #3509
Use c++11 for size test #3509
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3509
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit bda27d2 with merge base f9db02a (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #3509 Differential Revision: D57003591 Pulled By: lucylq
8d66fe5
to
2633953
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
Summary: Pull Request resolved: #3509 Differential Revision: D57003591 Pulled By: lucylq
2633953
to
a8596ec
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
Summary: Pull Request resolved: #3509 Differential Revision: D57003591 Pulled By: lucylq
a8596ec
to
4fb2169
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the string_view
changes from an aesthetic perspective, but they do look necessary.
Summary: Pull Request resolved: #3509 Reviewed By: swolchok Differential Revision: D57003591 Pulled By: lucylq
4fb2169
to
f592ffa
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
Summary: Pull Request resolved: #3509 Reviewed By: swolchok Differential Revision: D57003591 Pulled By: lucylq
f592ffa
to
ffc42c5
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
Summary: Pull Request resolved: #3509 Reviewed By: mergennachin, swolchok Differential Revision: D57003591 Pulled By: lucylq
ffc42c5
to
bda27d2
Compare
This pull request was exported from Phabricator. Differential Revision: D57003591 |
Summary: Pull Request resolved: #3509 Reviewed By: mergennachin, swolchok Differential Revision: D57003591 Pulled By: lucylq
No description provided.