get compile config back to EdgeProgramManager.transform #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3500
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 892b604 with merge base 3a2b2e8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Gasoonjia
force-pushed
the
export-D56804195
branch
from
07b5789
to
a7da085
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Gasoonjia
force-pushed
the
export-D56804195
branch
from
a7da085
to
ac4ad85
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
May 3, 2024
Summary: This diff brings compile config back to `EdgeProgramManager.transform` function, to make the EdgeDialectVerifier verify graph in a finer granularity, and not introduce too many attritute to the `transform` API. Differential Revision: D56804195
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
May 3, 2024
Summary: This diff brings compile config back to `EdgeProgramManager.transform` function, to make the EdgeDialectVerifier verify graph in a finer granularity, and not introduce too many attritute to the `transform` API. Differential Revision: D56804195
Gasoonjia
force-pushed
the
export-D56804195
branch
from
ac4ad85
to
5c09199
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
May 3, 2024
Summary: This diff introduces the compile configuration into the `EdgeProgramManager.transform` method, ensuring that the constructor and transform function of` EdgeProgramManager` maintain consistent verification configuration. The default verification configuration of `EdgeProgramManager.transform` will now match that of its constructor. This update brings two key improvements: 1. Enhanced Verification for the transform Function: With this update, we can now customize all necessary configuration verifiers within the `transform` function. 2. Improved Consistency within the `EdgeProgramManager` Class: Post-update, all verifiers within the same `EdgeProgramManager` will have identical functionality. This not only makes the logic more intuitive but also reduces redundancy in user settings. Reviewed By: JacobSzwejbka Differential Revision: D56804195
Gasoonjia
force-pushed
the
export-D56804195
branch
from
5c09199
to
5a5b062
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
May 3, 2024
Summary: This diff introduces the compile configuration into the `EdgeProgramManager.transform` method, ensuring that the constructor and transform function of` EdgeProgramManager` maintain consistent verification configuration. The default verification configuration of `EdgeProgramManager.transform` will now match that of its constructor. This update brings two key improvements: 1. Enhanced Verification for the transform Function: With this update, we can now customize all necessary configuration verifiers within the `transform` function. 2. Improved Consistency within the `EdgeProgramManager` Class: Post-update, all verifiers within the same `EdgeProgramManager` will have identical functionality. This not only makes the logic more intuitive but also reduces redundancy in user settings. Reviewed By: JacobSzwejbka Differential Revision: D56804195
Gasoonjia
force-pushed
the
export-D56804195
branch
from
5a5b062
to
29905e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
Summary: This diff introduces the compile configuration into the `EdgeProgramManager.transform` method, ensuring that the constructor and transform function of` EdgeProgramManager` maintain consistent verification configuration. The default verification configuration of `EdgeProgramManager.transform` will now match that of its constructor. This update brings two key improvements: 1. Enhanced Verification for the transform Function: With this update, we can now customize all necessary configuration verifiers within the `transform` function. 2. Improved Consistency within the `EdgeProgramManager` Class: Post-update, all verifiers within the same `EdgeProgramManager` will have identical functionality. This not only makes the logic more intuitive but also reduces redundancy in user settings. Reviewed By: JacobSzwejbka Differential Revision: D56804195
Gasoonjia
force-pushed
the
export-D56804195
branch
from
29905e7
to
892b604
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56804195 |
larryliu0820
approved these changes
May 3, 2024
|
This pull request has been merged in 834b545. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D56804195