make quantized model tests better #3495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3495
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25b6352 with merge base 4bd45c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56906440 |
Summary: XNNPACK should be testing with random inputs and quantized models should be calibrated before lowering and testing. Right now there are some numerical issues being debugged and tracked by: T187799178. this has been a bit difficult, but for now, we can first make these tests better by giving random inptus and enabling calibration. We don't fix the numerical issues in this diff. Differential Revision: D56906440
|
This pull request was exported from Phabricator. Differential Revision: D56906440 |
digantdesai
approved these changes
May 6, 2024
|
This pull request has been merged in 2835d01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
XNNPACK should be testing with random inputs and quantized models should be calibrated before lowering and testing. Right now there are some numerical issues being debugged and tracked by: T187799178. this has been a bit difficult, but for now, we can first make these tests better by giving random inptus and enabling calibration.
We don't fix the numerical issues in this diff.
Differential Revision: D56906440