Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SDK tutorial by moving cmake commands to a script #3492

Open
wants to merge 1 commit into
base: release/0.2
Choose a base branch
from
Open

Simplify SDK tutorial by moving cmake commands to a script #3492

wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

Address this comment. Tested the commands on mac locally and they worked. The script just generates etdump when working properly. I did "ls -l etdump.etdp" to check the timestamp.

@Olivia-liu @pytorchbot
Simplify SDK tutorial by moving cmake commands to a script (#3438)
6cd7122 
Summary:
As titled. Tested the commands on mac locally and they worked.

Pull Request resolved: #3438

Reviewed By: Jack-Khuu

Differential Revision: D56792240

Pulled By: Olivia-liu

fbshipit-source-id: dd62ea2fc788c5e1867d1e50037d7b4fd7e3a3f9
(cherry picked from commit a4ffd96)
@pytorchbot pytorchbot mentioned this pull request May 2, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 2, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3492

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6cd7122 with merge base d3326a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2024
@Olivia-liu Olivia-liu mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pytorchbot @facebook-github-bot @Olivia-liu