[ET-VK][15/n] reconcile Dim4D and NchwDim #3489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3489
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 155b61b with merge base c001f59 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56778340 |
yipjustin
added a commit
that referenced
this pull request
May 2, 2024
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) ghstack-source-id: 224867963 Pull Request resolved: #3489
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
yipjustin
added a commit
that referenced
this pull request
May 4, 2024
Pull Request resolved: #3489 TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) ghstack-source-id: 225119612
|
This pull request was exported from Phabricator. Differential Revision: D56778340 |
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
yipjustin
added a commit
that referenced
this pull request
May 4, 2024
Pull Request resolved: #3489 1. Adapt @SSJia's idea to represent `Dim4D` as a "negative index", and rename it as `DimIndex` 2. Merge `NchwDim`'s functionality with `Dim4D`. 3. Clean up `dim_at` call to assume only `DimIndex` as input. 4. Further clean up some usage of `uint` and convert them into `int`. ghstack-source-id: 225120658 Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/)
|
This pull request was exported from Phabricator. Differential Revision: D56778340 |
SS-JIA
approved these changes
May 6, 2024
TSIA. Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/) [ghstack-poisoned]
yipjustin
added a commit
that referenced
this pull request
May 8, 2024
Pull Request resolved: #3489 1. Adapt @SSJia's idea to represent `Dim4D` as a "negative index", and rename it as `DimIndex` 2. Merge `NchwDim`'s functionality with `Dim4D`. 3. Clean up `dim_at` call to assume only `DimIndex` as input. 4. Further clean up some usage of `uint` and convert them into `int`. ghstack-source-id: 225521662 Differential Revision: [D56778340](https://our.internmc.facebook.com/intern/diff/D56778340/)
|
This pull request was exported from Phabricator. Differential Revision: D56778340 |
|
This pull request has been merged in 251aa74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TSIA.
Differential Revision: D56778340