Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern template for binary bitwise ops #3486

Closed
wants to merge 7 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented May 2, 2024

Summary: Similar to D56744651.

Differential Revision: D56852163

Copy link

pytorch-bot bot commented May 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3486

Note: Links to docs will display an error until the docs builds have been completed.

❌ 34 New Failures

As of commit 58dba0c with merge base f227fc3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56852163

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56852163

swolchok added a commit to swolchok/executorch that referenced this pull request May 3, 2024
Summary:
Pull Request resolved: pytorch#3486

Similar to D56744651.

Differential Revision: D56852163
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56852163

swolchok added a commit to swolchok/executorch that referenced this pull request May 6, 2024
Summary:
Pull Request resolved: pytorch#3486

Similar to D56744651.

Differential Revision: D56852163
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56852163

swolchok added a commit to swolchok/executorch that referenced this pull request May 6, 2024
Summary:
Pull Request resolved: pytorch#3486

Similar to D56744651.

Differential Revision: D56852163
…ch#3459)

Summary:

Yet another smaller pair of ops.

Reviewed By: manuelcandales

Differential Revision: D56807402
…ytorch#3455)

Summary:

Continuing rollout of this technique.

Reviewed By: manuelcandales

Differential Revision: D56827786
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
…3456)

Summary:

Almost done with Tensor ops that can benefit from compile-time promotion!

Reviewed By: manuelcandales

Differential Revision: D56835200
Summary:

IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum.

Reviewed By: manuelcandales

Differential Revision: D56846242
Summary:

Noticed this inconsistency with clamp.

Reviewed By: manuelcandales

Differential Revision: D56846313
Summary:

Similar to D56744651.

Differential Revision: D56852163
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56852163

swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
Summary:

Similar to D56744651.

Differential Revision: D56852163
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
Summary:

Similar to D56744651.

Differential Revision: D56852163
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
Summary:

Similar to D56744651.

Differential Revision: D56852163
@swolchok
Copy link
Contributor Author

swolchok commented May 7, 2024

selective build requires constexpr op names, so we can't refactor core parts of ops into template functions until/unless we come up with another way to do selective build.

@swolchok swolchok closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants