support Half in minimum and clamp #3457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3457
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 41cf1aa with merge base 8a5668a ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: pytorch#3457 IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: pytorch#3457 IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
manuelcandales
approved these changes
May 7, 2024
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 8, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
…ch#3459) Summary: Yet another smaller pair of ops. Reviewed By: manuelcandales Differential Revision: D56807402
…ytorch#3455) Summary: Continuing rollout of this technique. Reviewed By: manuelcandales Differential Revision: D56827786
…orch#3458) Summary: Yet another op that can benefit from compile-time type promotion. Reviewed By: manuelcandales Differential Revision: D56831293
…3456) Summary: Almost done with Tensor ops that can benefit from compile-time promotion! Reviewed By: manuelcandales Differential Revision: D56835200
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 8, 2024
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
|
This pull request was exported from Phabricator. Differential Revision: D56846242 |
|
This pull request has been merged in 7841e96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum.
Reviewed By: manuelcandales
Differential Revision: D56846242