Molly/enable unet1d #2242
Molly/enable unet1d #2242
Conversation
|
Hi @DiweiSun! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
@chuanqi129 , could you please kindly help review? |
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
| eval_benchmark: true | ||
| eval_deterministic: false | ||
| eval_nograd: true | ||
| train_benchmark: true |
There was a problem hiding this comment.
Does this model support train test?
There was a problem hiding this comment.
Not yet. This should be a mistake. Thanks for pointing out.
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
DiweiSun
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Enabling Unet1d to track OP performance:conv_transpose1d.
This PR is to enable Huggingface/Diffusers/UNET1D which includes conv_transpose1d on upsampling and downsampling phase.
(In #120982, a remarkable performance regression happens to conv_transpose1d. )
Note: Torch.profiling Detail suggests: conv_transposed accounts for 5% of the total time consumption in UNET1D.
Verified on Torch2.2 and Torch 1.13.1 with default config, with the following cmd
numactl -C 0 python run.py unet1d (The test scripts refer to https://huggingface.co/docs/diffusers/quicktour)
Torch 2.2 where conv_tranpose1d contributes 2.2ms
CPU Wall Time per batch: 10.803 milliseconds
CPU Wall Time: 10.803 milliseconds
Time to first batch: 25.9873 ms
CPU Peak Memory: 0.5264 GB
Torch 1.13 where conv_transpose1d contributes 0.8ms
CPU Wall Time per batch: 10.365 milliseconds
CPU Wall Time: 10.365 milliseconds
Time to first batch: 24.0618 ms
CPU Peak Memory: 0.4609 GB