Add explicit APIs in BenchmarkModel #1459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
approved these changes
Mar 7, 2023
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This will likely have to wait until #1457 is landed for the test cases to pass |
janeyx99
force-pushed
the
explicit-BM-API
branch
from
d1f114c
to
e565520
Compare
Update is_staged_train_test to check whether functions are actually implemented
janeyx99
force-pushed
the
explicit-BM-API
branch
from
e565520
to
d19d54b
Compare
|
@janeyx99 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of adding ways to more granularly benchmark.
Also explicitly document what methods we expect BenchmarkModels to have.