Parametrize test_lib_pack.py #8026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Apr 28, 2024
| mode: str, rawmode: str, data: int | bytes, pixels: list[float | tuple[int, ...]] | ||
| ) -> None: | ||
| with pytest.raises(ValueError): | ||
| test_unpack(mode, rawmode, data, pixels) |
There was a problem hiding this comment.
Calling one test from another seems odd, and a potential source of confusion?
There was a problem hiding this comment.
I could make test_unpack not a test function, and have all three test functions call that, but I don't see how that would be any clearer.
Yay295
force-pushed
the
parametrize_test_lib_pack
branch
from
84850ef
to
7a474fc
Compare
Yay295
force-pushed
the
parametrize_test_lib_pack
branch
from
b0a2b1e
to
1fa2ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.