Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set --remote-debugging-address option #14

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

theonlynexus
Copy link

In certain situations the 127.0.0.1 address might not work, so allow the user to pass a listening address (IP) to chromium-headless

@Granitosaurus Granitosaurus added the enhancement New feature or request label Feb 23, 2020
Mattwmaster58
Mattwmaster58 previously approved these changes Feb 25, 2020
@Mattwmaster58
Copy link
Member

Are you aware of whether this functionality exists in puppeteer @theonlynexus? If so, there's a very good chance this has been implemented in the pup2.1.1 branch - making this PR moot.

@Mattwmaster58 Mattwmaster58 dismissed their stale review March 12, 2020 02:49

no longer applicable - see comment

@theonlynexus
Copy link
Author

Are you aware of whether this functionality exists in puppeteer @theonlynexus? If so, there's a very good chance this has been implemented in the pup2.1.1 branch - making this PR moot.

Sorry, I sincerely have no idea. I had just pulled pyppeteer from the main repo, saw that I had issues (including the timeout on browser span which has been solved by a different commit by @Granitosaurus, I believe), fixed the issues and asked for a place to post them, since I couldn't find a pyppeteer2 official repo.

@Mattwmaster58
Copy link
Member

Fair enough. This PR will be on hold until #16 lands and we can re-verify the features (non?)existence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants