Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thrift fix: eta data #3674

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Thrift fix: eta data #3674

wants to merge 1 commit into from

Conversation

snilt
Copy link

@snilt snilt commented Jun 23, 2020

To reproduce the issue:

  1. Start a server with an empty queue
  2. From the webinterface:
    Pause the server
    Disable download speed limit
    Add some valid package to download (preferably some large file, couple of gigabytes)
  3. Start the CLI and unpause the server

Traceback (most recent call last):
...
...
File "/home/snilt/pyload/module/lib/thrift/protocol/TBinaryProtocol.py", line 110, in writeI32
buff = pack("!i", i32)
error: 'i' format requires -2147483648 <= number <= 2147483647

It seems that the server sends some bad eta value at the very beginning of a new download.
The PR just changes the data format to integer 64-bit.
(Works fine for me since years)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vuolter
Copy link
Contributor

vuolter commented Aug 19, 2020

This PR is for pyLoad Stable, but I have to inform you that thrift is no longer supported in pyLoad Next.

@GammaC0de
Copy link
Member

but I have to inform you that thrift is no longer supported in pyLoad Next.

@vuolter Thrift is also used by the Android app...

@vuolter
Copy link
Contributor

vuolter commented Aug 19, 2020

I think we can add it as a separate package, even I actually don't like it so much to be honest.

@vuolter vuolter added the enhancement New feature or bugfix label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or bugfix
Development

Successfully merging this pull request may close these issues.

None yet

4 participants