-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the CLI (SSL ThriftBackend) #3673
base: stable
Are you sure you want to change the base?
Conversation
Hello @snilt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-07-13 17:07:12 UTC |
|
Here is an overview of what got changed by this pull request: Clones added
============
- module/remote/thriftbackend/Socket.py 1
- module/remote/thriftbackend/ThriftClient.py 2
See the complete overview on Codacy |
Can you give a brief explanation about this issue? |
With ssl thriftbackend enabled on the server, when i start the cli, it hangs during connecting to server. (About the pyopenssl issue I'm not sure if it is related. First post edited) |
The ThriftClient doesn't work with current versions of pyOpenSSL.
This could possibly be related to: pyca/pyopenssl#168
The PR adds a timeout to the SecureSocketConnection class, which should work for any pyOpenSSL version, even the ancient not-cffi-based versions.
Since ThriftClient auto-detects if a server uses SSL, the socket timeout values are kept low to speed up the detection. This possibly can lead to problems on high latency network connections, the PR adds a command line option to the CLI to bypass the detection and use a higher timeout.
Tested on:
Debian Stretch, pyOpenSSL 16.2.0
Debian Jessie, pyOpenSSL 0.14
Windows 10, pyOpenSSL 19.1.0
Windows 10, pyOpenSSL 0.13.16 (egenix)