Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix screenshot guide #12451

Merged
merged 1 commit into from
May 17, 2024
Merged

docs: fix screenshot guide #12451

merged 1 commit into from
May 17, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented May 16, 2024

Closes #12429

@OrKoN OrKoN force-pushed the orkon/fix-screenshot-guide branch from 41b4459 to dcdb599 Compare May 16, 2024 11:42
@OrKoN OrKoN force-pushed the orkon/fix-screenshot-guide branch from dcdb599 to 3e89951 Compare May 16, 2024 18:09
Lightning00Blade
Lightning00Blade reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct fix but as pointed by the other PR the extension in the example is wrong as well.
There it's .pdf which I'm not sure if it work as we try to infer the type from the it.
We should fix that as well.

@OrKoN OrKoN force-pushed the orkon/fix-screenshot-guide branch from 3e89951 to ca1aa76 Compare May 17, 2024 06:01
@OrKoN OrKoN force-pushed the orkon/fix-screenshot-guide branch from ca1aa76 to e3e15bc Compare May 17, 2024 06:01
@OrKoN OrKoN force-pushed the orkon/fix-screenshot-guide branch from e3e15bc to 31f7701 Compare May 17, 2024 06:08
@OrKoN OrKoN enabled auto-merge (squash) May 17, 2024 06:08
@OrKoN OrKoN merged commit 6dd3aa7 into main May 17, 2024
21 checks passed
@OrKoN OrKoN deleted the orkon/fix-screenshot-guide branch May 17, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrKoN @Lightning00Blade