Support Parameterize in get-schema, gen-sdk #16210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-17) |
Frassle
added
impact/no-changelog-required
Frassle
force-pushed
the
fraser/paramCmd
branch
4 times, most recently
from
9efe885
to
5053f5f
Compare
Frassle
changed the title
iwahbe
reviewed
May 16, 2024
Frassle
force-pushed
the
fraser/paramCmd
branch
2 times, most recently
from
dac94fe
to
944b984
Compare
julienp
approved these changes
May 17, 2024
tgummerer
reviewed
May 17, 2024
Frassle
force-pushed
the
fraser/paramCmd
branch
2 times, most recently
from
e218f5a
to
ebdc7fc
Compare
iwahbe
reviewed
May 17, 2024
| @@ -25,16 +25,18 @@ import ( | |||
|
|
|||
| func newExtractSchemaCommand() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "get-schema <schema_source>", | |||
| Args: cobra.ExactArgs(1), | |||
| Use: "get-schema <schema_source> [provider parameters]", | |||
There was a problem hiding this comment.
I would go with a repeatable flag here, not arbitrary args:
pulumi package get-schema terraform-bridge --param name=random -p version='>=3'
Instead of
pulumi package get-schema terraform-bridge name=random version='>=3'
There was a problem hiding this comment.
Seems a lot more verbose, not clear what the win is there?
There was a problem hiding this comment.
My preference is to have binary command [sumcommands] [--modifiers]. Feel free to ignore me if you disagree.
There was a problem hiding this comment.
yeh gonna go with this feels more natural to me for now
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This plumbs the use of the Parameterize method and GetSchema into get-schema (and gen-sdk partially, not that sdk gen can actually deal with it yet properly).
It also happens to fix get-schema working better for shimless providers (i.e. pointing to a folder and using the language host to run it).
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change