[engine/import] Guess ID references of dependant resources when generating code for import operations

[Zaid-Ajaj]

Description

Taking an initial attempt at #10025 where we now try to guess ID references of dependant resources instead of writing out the IDs as literal values.
Instead of:

// has ID=provider-generated-bucket-id-abc123
resource exampleBucket "aws:s3/bucket:Bucket" {}

resource exampleBucketObject "aws:s3/bucketObject:BucketObject" {
    bucket = "provider-generated-bucket-id-abc123"
    storageClass = "STANDARD"
}

We generate:

resource exampleBucket "aws:s3/bucket:Bucket" {}

resource exampleBucketObject "aws:s3/bucketObject:BucketObject" {
    bucket = exampleBucket.id
    storageClass = "STANDARD"
}

This implies a dependency between exampleBucketObject and exampleBucket without explicitly being added into the dependsOn array (it would be redundant)

Checklist

• I have run make tidy to update any new dependencies
• I have run make lint to verify my code passes the lint check
  • I have formatted my code using gofumpt

• I have added tests that prove my fix is effective or that my feature works

• I have run make changelog and committed the changelog/pending/<file> documenting my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

[pulumi-bot]

Changelog

[uncommitted] (2024-05-20)

Features

• [engine] Guess ID references of dependant resources when generating code for import operations
  #16208

[Frassle]

What if multiple resources have the same ID? Do we just pick one randomly, or fall back to the literal string?

[Zaid-Ajaj]

What if multiple resources have the same ID? Do we just pick one randomly, or fall back to the literal string?

I didn't think about that 🤔 right now this will pick the first ID that was detected. I think if we want to be deterministic, we would have to remove ambiguous references to the same ID and the program would fall back to the literal value. However, if this is a highly unlikely event, we can maybe keep it as is.

[Zaid-Ajaj]

@Frassle I've updated the PR such that now when multiple resources have the same ID, we don't make a reference to any of them and instead use the literal value instead. More generally, pathed values with different paths but equal values are removed. This will work nicely without any ambiguity when we extend the pathed values not just for {resource}.id but for any output of a resource used an input for another resource

[justinvp]

Suggested change

	onRefereceAdded := func(string) {}
	onReferenceAdded := func(string) {}

[Zaid-Ajaj]

Done ✅