-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): replace dynamic import for wasm-worker-loader
with static export
#23754
Conversation
wasm-worker-loader
with static exportwasm-worker-loader
with static export
Thank you @smorimoto for this PR. To summarise the context around this PR for other internal reviewers:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Glad this is getting fixed. Thank you 🙏🏼 🙏🏼 🙏🏼 🙏🏼
@jkomyno We migrated some of our projects to the Node.js runtime for performance, but we're still using this patch for some projects that use the Edge runtime, and we don't see any issues, and in theory we don't expect any issues. What are your concerns about merging this? |
…tic export Signed-off-by: Sora Morimoto <sora@morimoto.io>
Hi @smorimoto, here's some updates on our side:
As posted in #23600 (comment), may you please another new unofficial version of Prisma, and report back if it keeps working for your scenario? You can quickly install it via:
(please double check that prisma generate has run before retrying). |
I'm now closing this PR in favor of #24312, which was merged and is part of the upcoming Prisma release, 5.15.0 (coming out today!). Thanks @smorimoto for the inspiration and contribution! |
@jkomyno All right. It would be more polite to set me and @nzws as co-authors on Git from now on :) |
Fixes #23600
As I understand, since dynamic import is not necessary here, we can easily fix the linked issue.
Is there anything I am missing?
I'm actually using this patch in my runtime environment and I don't see any performance issues either.