Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): replace dynamic import for wasm-worker-loader with static export #23754

Closed
wants to merge 1 commit into from

Conversation

smorimoto
Copy link

@smorimoto smorimoto commented Apr 7, 2024

Fixes #23600

As I understand, since dynamic import is not necessary here, we can easily fix the linked issue.
Is there anything I am missing?
I'm actually using this patch in my runtime environment and I don't see any performance issues either.

@smorimoto smorimoto requested a review from a team as a code owner April 7, 2024 06:45
@smorimoto smorimoto requested review from Druue and removed request for a team April 7, 2024 06:45
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2024

CLA assistant check
All committers have signed the CLA.

@jkomyno
Copy link
Contributor

jkomyno commented Apr 29, 2024

Thank you @smorimoto for this PR.
I think the next course of action for us is to merge this and observe the impact on our ecosystem-tests.

To summarise the context around this PR for other internal reviewers:

Copy link

@Vinlock Vinlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad this is getting fixed. Thank you 🙏🏼 🙏🏼 🙏🏼 🙏🏼

@smorimoto
Copy link
Author

@jkomyno We migrated some of our projects to the Node.js runtime for performance, but we're still using this patch for some projects that use the Edge runtime, and we don't see any issues, and in theory we don't expect any issues. What are your concerns about merging this?

…tic export

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@jkomyno
Copy link
Contributor

jkomyno commented May 30, 2024

Hi @smorimoto, here's some updates on our side:

As posted in #23600 (comment), may you please another new unofficial version of Prisma, and report back if it keeps working for your scenario? 5.15.0-integration-client-dynamic-wasm-imports.1

You can quickly install it via:

pnpm add -D prisma@5.15.0-integration-client-dynamic-wasm-imports.1;
pnpm update "@prisma/*" 5.15.0-integration-client-dynamic-wasm-imports.1

(please double check that prisma generate has run before retrying).
We expect this to be released with Prisma 5.15.0 next week. Thanks!

@jkomyno
Copy link
Contributor

jkomyno commented Jun 4, 2024

Hi @smorimoto, here's some updates on our side:

As posted in #23600 (comment), may you please another new unofficial version of Prisma, and report back if it keeps working for your scenario? 5.15.0-integration-client-dynamic-wasm-imports.1

You can quickly install it via:

pnpm add -D prisma@5.15.0-integration-client-dynamic-wasm-imports.1;
pnpm update "@prisma/*" 5.15.0-integration-client-dynamic-wasm-imports.1

(please double check that prisma generate has run before retrying). We expect this to be released with Prisma 5.15.0 next week. Thanks!

I'm now closing this PR in favor of #24312, which was merged and is part of the upcoming Prisma release, 5.15.0 (coming out today!).

Thanks @smorimoto for the inspiration and contribution!

@jkomyno jkomyno closed this Jun 4, 2024
@smorimoto smorimoto deleted the fix-23600 branch June 4, 2024 17:27
@smorimoto
Copy link
Author

@jkomyno All right. It would be more polite to set me and @nzws as co-authors on Git from now on :)
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js app build fails when using Prisma with DB driver in Server Action
5 participants