Decompile frontier_cmd_arcade #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus misc frontier system funcs
|
Ready for review |
adrienntindall
changed the title
red031000
requested changes
Apr 17, 2024
PikalaxALT
requested changes
Apr 19, 2024
Back from my plat vacation (for now) mostly just put it off cause I didn't want to rename 100 functions (but I will)
red031000
previously approved these changes
Jun 2, 2024
Draft
PikalaxALT
requested changes
Jun 6, 2024
| @@ -64,7 +64,7 @@ u32 BattleArcadeData_Alloc(SaveData *saveData, u32 a1, u8 a2, u32 a3, u32 a4, u3 | |||
| void BattleArcadeData_Init(void *a0, u32 a1); | |||
| void BattleArcadeData_Free(void *a0); | |||
| u8 BattleArcade_GetWonBattlePoints(ArcadeContext *ctx, Party *playerParty, Party *opponentParty, int a3); | |||
| void ov80_02235364(Party *a0, Party *a1, int a2, int a3); | |||
| void ov80_02235364(Party *party, Party *playerParty, int a2, int a3); | |||
There was a problem hiding this comment.
what's the difference between these two Party * parameters?
There was a problem hiding this comment.
not 100% sure since that specific function isn't decompiled yet, it's something related to the roulette event that swaps (some) of your party mons with the opponents party mons though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with the battle arcade cause I wanna use specifically that for a project