add an option to register a service as https and call https services

[krysalead]

Hi,

Sorry for the formatting it seems that some space were missing in front of the comments and I don't know how to remove this indentation from Visual Studio Code.
Changes are not that big, only a new config key
serviceProtocol which could be http or https (default is http)
The other change is that if the service was registered as https it will be called with https.

[krysalead]

Hi,

I had to change the eslintrc to make it work from command line, tell me if it is breaking on your side.
I am using VS code

[krysalead]

Documentation

HTTPS

If you build your microservice not behing a firewall but using different hosting service you will like to run it in HTTPS for security reason. This is doable in Hydra as simply as setting the service protocol to https.

{
    "serviceName": "echo-service",
    "serviceIP": "127.0.0.1",
    "servicePort": 3000,
    "serviceType": "",
    "serviceDescription": "",
    "serviceProtocol": "https",
    "redis": {
      "url": "127.0.0.1",
      "port": 6379,
      "db": 1
    }
  }
}

Your service will be registered in redis as secured and will be called using HTTPS. Nothing additional to do in your call to the service.

If you are not using a revers-proxy handeling the SSL encryption you will need to use hydra-express for instance that is starting a server in HTTPS if you specify https in protocol see hydra-express documentation for more information.

[cjus]

@krysalead thanks for this PR. In reviewing it there seems to be a lot of formatting changes. I do agree that those format changes should be done - but I'd rather do that in another PR. Can you branch and only apply your core changes in a new PR?

[krysalead]

Hi,

I am really struggling to make it properly, there is inconsistency everywhere, spaces sometimes added, sometimes not. Isn't simpler to do the review with comparison without white space activated?

[cjus]

Question and minor feedback

[cjus]

Why is this necessary?

[krysalead]

It was not loading google eslint config in my environement, I manage to make it work like that but I can revert it.

[cjus]

or: protocol: ${(instance.protocol || 'http')}:,

[krysalead]

If you prefer, I am still not use to litterals on small piece of string.

[cjus]

@krysalead No worries about the spaces - I can cleanup after if necessary. See my questions and comment. Thanks again.

[JustusFluegel]

maybe consider using the modern ?? syntax instead of || like a ?? "default"

see https://dev.to/hereisnaman/logical-or-vs-nullish-coalescing-operator-in-javascript-3851 for details