Additional tenant settings from api/SPOInternalUseOnly.TenantAdminSettings #3902
Conversation
|
Hey @reshmee011, thank you very much for your support! :) See my PN in X chat regarding this. 💪 |
gautamdsheth
force-pushed
the
tenantsettingsinternaluse
branch
2 times, most recently
from
94f93e8
to
4c4a011
Compare
reshmee011
force-pushed
the
tenantsettingsinternaluse
branch
from
37b83c5
to
6982aa1
Compare
|
Sorry accidentally closed while trying to fix the build issues and refactoring the code to be a separate cmdlet instead |
|
@reshmee011 - can you change to singular |
|
@gautamdsheth : I have update it to be singular internalsetting. Thanks for the review. |
| using Microsoft.Online.SharePoint.TenantAdministration; | ||
| using Microsoft.Online.SharePoint.TenantManagement; | ||
| using Microsoft.SharePoint.Client; | ||
| using Newtonsoft.Json; |
There was a problem hiding this comment.
Ahh, sorry missed this !
We use System.Text.Json for serializing/de-serializing JSON.
Can you please remove the Newtonsoft.Json reference ? We also need to use JsonPropertyName instead of JsonProperty. Let me know if you need help here.
|
@gautamdsheth : I have updated to use "System.Text.Json;". Thanks very much for the review. |
|
Merged it , thank you!! |
Before creating a pull request, make sure that you have read the contribution file located at
There are additional settings available from https://contoso-admin.sharepoint.com/_api/SPOInternalUseOnly.TenantAdminSettings. Adding those to Get-PnPTenant will make it easier to retrieve these properties for governance or inventory purposes.
Original idea was from Tobias Maestrini and I helped implement the retrieval of these properties.
Type
Three new files to support the cmdlet
documentation\Get-PnPTenantInternalSetting.md
src\Commands\Model\SPOTenantInternalSetting.cs
src\Commands\Admin\GetTenantInternalSetting.cs
What is in this Pull Request ?
Additional tenant properties available from /_api/SPOInternalUseOnly.TenantAdminSettings