Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide read stories using HN built-in hide for logged-in users #91

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telotortium
Copy link

This will ensure that these stories are hidden across all logged-in devices.

Fixes #90.

This will ensure that these stories are hidden across all logged-in
devices.
@telotortium
Copy link
Author

telotortium commented Jan 22, 2021

Don't merge yet -- TODO:

  • Add an onclick handler to the stories and comments on the HN front page so that stories are hidden when you click on them. Right now, they're only hidden the next time the page is reloaded.
  • On comment page load, hide the story if it's not already hidden.
  • Maybe add a toggle to disable the extension's hiding mechanism, in case you always browsed logged-in (like I do).
  • Maybe don't hide stories that you've favorited.

@plibither8
Copy link
Owner

@telotortium hey! Any updates on this? 🙂

@telotortium
Copy link
Author

Sorry, I haven't had time to work on it. If you want to help finish the PR, that would be helpful, but I otherwise won't have time for a while.

@plibither8
Copy link
Owner

plibither8 commented Aug 3, 2021 via email

@plibither8 plibither8 marked this pull request as draft December 17, 2021 19:29
@plibither8 plibither8 changed the base branch from master to main September 25, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide stories with Hacker News' builtin hide feature when logged in
2 participants