Refactor PWD to use SDK #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosnils
force-pushed
the
pwd_sdk
branch
3 times, most recently
from
c00fbd5
to
7f3f9e6
Compare
Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
This new pattern allows to take advantage of the existing GFM syntax like: ```.term docker run hello-world ``` With this new approach, the SDK will run that code on the specified matched by the selector
Closed
|
too bad this has conflicts now. @xetorthio 😠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xetorthio try to be as picky as you can with this PR as it's important. And try to test it before merging plz.